Update patch set 8
Patch Set 8: (9 comments) Patch-set: 8 Label: Verified=0
This commit is contained in:
Gerrit User 28208
Gerrit Code Review
parent
1df6179626
commit
6a089e1518
|
|
@ -46,6 +46,23 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_646066d0",
|
||||
"filename": "specs/approved/airshictl_bootstrap_image.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 21,
|
||||
"author": {
|
||||
"id": 28208
|
||||
},
|
||||
"writtenOn": "2019-08-19T17:24:05Z",
|
||||
"side": 1,
|
||||
"message": ".",
|
||||
"revId": "52280370556a3b0472e422f2f17a6ac88d15e3bb",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_b261cb3b",
|
||||
|
|
@ -69,6 +86,23 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_64e38635",
|
||||
"filename": "specs/approved/airshictl_bootstrap_image.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 59,
|
||||
"author": {
|
||||
"id": 28208
|
||||
},
|
||||
"writtenOn": "2019-08-19T17:24:05Z",
|
||||
"side": 1,
|
||||
"message": "_",
|
||||
"revId": "52280370556a3b0472e422f2f17a6ac88d15e3bb",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_d266c751",
|
||||
|
|
@ -86,6 +120,52 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_24382e9e",
|
||||
"filename": "specs/approved/airshictl_bootstrap_image.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 71,
|
||||
"author": {
|
||||
"id": 28208
|
||||
},
|
||||
"writtenOn": "2019-08-19T17:24:05Z",
|
||||
"side": 1,
|
||||
"message": "Could it be part of YAML spec? What do you think?",
|
||||
"range": {
|
||||
"startLine": 71,
|
||||
"startChar": 2,
|
||||
"endLine": 71,
|
||||
"endChar": 23
|
||||
},
|
||||
"revId": "52280370556a3b0472e422f2f17a6ac88d15e3bb",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_44d68a51",
|
||||
"filename": "specs/approved/airshictl_bootstrap_image.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 71,
|
||||
"author": {
|
||||
"id": 28208
|
||||
},
|
||||
"writtenOn": "2019-08-19T17:24:05Z",
|
||||
"side": 1,
|
||||
"message": "not url, just image",
|
||||
"range": {
|
||||
"startLine": 71,
|
||||
"startChar": 56,
|
||||
"endLine": 71,
|
||||
"endChar": 59
|
||||
},
|
||||
"revId": "52280370556a3b0472e422f2f17a6ac88d15e3bb",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_925ccf7d",
|
||||
|
|
@ -126,6 +206,115 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_44320aa9",
|
||||
"filename": "specs/approved/airshictl_bootstrap_image.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 111,
|
||||
"author": {
|
||||
"id": 28208
|
||||
},
|
||||
"writtenOn": "2019-08-19T17:24:05Z",
|
||||
"side": 1,
|
||||
"message": "boot_image_type (if you decide it\u0027s needed)",
|
||||
"range": {
|
||||
"startLine": 111,
|
||||
"startChar": 6,
|
||||
"endLine": 111,
|
||||
"endChar": 16
|
||||
},
|
||||
"revId": "52280370556a3b0472e422f2f17a6ac88d15e3bb",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_447a0a88",
|
||||
"filename": "specs/approved/airshictl_bootstrap_image.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 116,
|
||||
"author": {
|
||||
"id": 28208
|
||||
},
|
||||
"writtenOn": "2019-08-19T17:24:05Z",
|
||||
"side": 1,
|
||||
"message": "Probably not needed, as iso image could be usually used also as a flash image (with MBR): https://wiki.syslinux.org/wiki/index.php?title\u003dIsohybrid",
|
||||
"range": {
|
||||
"startLine": 115,
|
||||
"startChar": 0,
|
||||
"endLine": 116,
|
||||
"endChar": 17
|
||||
},
|
||||
"revId": "52280370556a3b0472e422f2f17a6ac88d15e3bb",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_64ff06ab",
|
||||
"filename": "specs/approved/airshictl_bootstrap_image.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 117,
|
||||
"author": {
|
||||
"id": 28208
|
||||
},
|
||||
"writtenOn": "2019-08-19T17:24:05Z",
|
||||
"side": 1,
|
||||
"message": "boot_image_path",
|
||||
"range": {
|
||||
"startLine": 117,
|
||||
"startChar": 6,
|
||||
"endLine": 117,
|
||||
"endChar": 20
|
||||
},
|
||||
"revId": "52280370556a3b0472e422f2f17a6ac88d15e3bb",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_04289230",
|
||||
"filename": "specs/approved/airshictl_bootstrap_image.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 123,
|
||||
"author": {
|
||||
"id": 28208
|
||||
},
|
||||
"writtenOn": "2019-08-19T17:24:05Z",
|
||||
"side": 1,
|
||||
"message": "Missing template for cloud-init file/ignite file.",
|
||||
"revId": "52280370556a3b0472e422f2f17a6ac88d15e3bb",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_a4d09e20",
|
||||
"filename": "specs/approved/airshictl_bootstrap_image.rst",
|
||||
"patchSetId": 8
|
||||
},
|
||||
"lineNbr": 132,
|
||||
"author": {
|
||||
"id": 28208
|
||||
},
|
||||
"writtenOn": "2019-08-19T17:24:05Z",
|
||||
"side": 1,
|
||||
"message": "Why? If we would not join newly launched hosts into this k8s cluster which starts on an ephemeral host, then we wouldn\u0027t be able to e.g. move metal3.io/ironic workload from ephemeral host onto another host.",
|
||||
"range": {
|
||||
"startLine": 132,
|
||||
"startChar": 6,
|
||||
"endLine": 132,
|
||||
"endChar": 19
|
||||
},
|
||||
"revId": "52280370556a3b0472e422f2f17a6ac88d15e3bb",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_32dabbe8",
|
||||
|
|
|
|||
Loading…
Reference in New Issue