Update patch set 13
Patch Set 13: (8 comments) Patch-set: 13
This commit is contained in:
Gerrit User 22259
Gerrit Code Review
parent
beb1a1b1bb
commit
682eb0e322
|
|
@ -620,6 +620,29 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_c1f0f893",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 368,
|
||||
"author": {
|
||||
"id": 22259
|
||||
},
|
||||
"writtenOn": "2019-07-01T22:19:36Z",
|
||||
"side": 1,
|
||||
"message": "Airship",
|
||||
"range": {
|
||||
"startLine": 368,
|
||||
"startChar": 4,
|
||||
"endLine": 368,
|
||||
"endChar": 11
|
||||
},
|
||||
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_7552813d",
|
||||
|
|
@ -643,6 +666,52 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_2124740c",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 378,
|
||||
"author": {
|
||||
"id": 22259
|
||||
},
|
||||
"writtenOn": "2019-07-01T22:19:36Z",
|
||||
"side": 1,
|
||||
"message": "I am assumming the below options mentioned are meant to be running against a live cluster? Please correct my understanding.\nIf yes then do we want to have an option here to `generate` the bundle for a given `site` similar to `pegleg collect`.\n\nWill the document lifecycle look like below?:\n- generate bundle\n- push the bundle to the site as a secret i.e. ``document \n apply``\n- armada or whatever tool will reference this secret as part of argo workflow to then create these resources ie. ``armada apply`` or similar to ``armada_build``\n\nAlso we can do multiple ``apply`` of this bundle, do we intend to store versions for this bundle?",
|
||||
"range": {
|
||||
"startLine": 378,
|
||||
"startChar": 0,
|
||||
"endLine": 378,
|
||||
"endChar": 18
|
||||
},
|
||||
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_41964840",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 387,
|
||||
"author": {
|
||||
"id": 22259
|
||||
},
|
||||
"writtenOn": "2019-07-01T22:19:36Z",
|
||||
"side": 1,
|
||||
"message": "- what does `specific manifest` mean here?",
|
||||
"range": {
|
||||
"startLine": 387,
|
||||
"startChar": 36,
|
||||
"endLine": 387,
|
||||
"endChar": 77
|
||||
},
|
||||
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_634e5d39",
|
||||
|
|
@ -666,6 +735,29 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_c156b82a",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 430,
|
||||
"author": {
|
||||
"id": 22259
|
||||
},
|
||||
"writtenOn": "2019-07-01T22:19:36Z",
|
||||
"side": 1,
|
||||
"message": "is this somewhat similar to a cookiecutter creating a basic template for users who want to create their own site documents from scratch?\nAfter looking at the statement in L437, it maybe useful for this command to take flags so that if user wants to just give a try to Airship then they can clone a working stable type from treasuremap and be good to go or if they want to build from scratch they use the flag to create a basic template",
|
||||
"range": {
|
||||
"startLine": 430,
|
||||
"startChar": 5,
|
||||
"endLine": 430,
|
||||
"endChar": 35
|
||||
},
|
||||
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_0338c19d",
|
||||
|
|
@ -689,6 +781,75 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_1c38b3d0",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 508,
|
||||
"author": {
|
||||
"id": 22259
|
||||
},
|
||||
"writtenOn": "2019-07-01T22:19:36Z",
|
||||
"side": 1,
|
||||
"message": "typo",
|
||||
"range": {
|
||||
"startLine": 508,
|
||||
"startChar": 115,
|
||||
"endLine": 508,
|
||||
"endChar": 124
|
||||
},
|
||||
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_dcb0db42",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 540,
|
||||
"author": {
|
||||
"id": 22259
|
||||
},
|
||||
"writtenOn": "2019-07-01T22:19:36Z",
|
||||
"side": 1,
|
||||
"message": "what would these specific preparation task would be that cannot be achieved via making manifest changes to BMH and Machine spec and let the cluster API machine controller drive the redeployment as part of `sitemanage update_site` WF",
|
||||
"range": {
|
||||
"startLine": 539,
|
||||
"startChar": 85,
|
||||
"endLine": 540,
|
||||
"endChar": 118
|
||||
},
|
||||
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_9c882371",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 554,
|
||||
"author": {
|
||||
"id": 22259
|
||||
},
|
||||
"writtenOn": "2019-07-01T22:19:36Z",
|
||||
"side": 1,
|
||||
"message": "Duplicated",
|
||||
"range": {
|
||||
"startLine": 552,
|
||||
"startChar": 0,
|
||||
"endLine": 554,
|
||||
"endChar": 65
|
||||
},
|
||||
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_63b97d13",
|
||||
|
|
@ -711,6 +872,23 @@
|
|||
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9fb8cfa7_fc983fc0",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 13
|
||||
},
|
||||
"lineNbr": 593,
|
||||
"author": {
|
||||
"id": 22259
|
||||
},
|
||||
"writtenOn": "2019-07-01T22:19:36Z",
|
||||
"side": 1,
|
||||
"message": "This section can be utilized to include all the reference link used in the document similar to other specs.",
|
||||
"revId": "0765cb6d8e83ea0919b6efbb5eb9e027b8cdc55a",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue