Update patch set 15
Patch Set 15: Code-Review-1 (13 comments) Looks really good already. Some more comments and questions. Patch-set: 15 Reviewer: Gerrit User 24580 <24580@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
Gerrit User 24580
Gerrit Code Review
parent
b6f1a5ff71
commit
5d42759f51
|
|
@ -17,6 +17,23 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_2a2122fc",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 46,
|
||||
"author": {
|
||||
"id": 24580
|
||||
},
|
||||
"writtenOn": "2019-07-30T17:54:05Z",
|
||||
"side": 1,
|
||||
"message": "It is not clear here whether Deckhand will vanish as a long running service in 2.0. Is that still TBD?",
|
||||
"revId": "2a58dd3457df06aa11dc1e63a0aa7acd768068b2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_d65e1e44",
|
||||
|
|
@ -40,6 +57,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_2ae4c2ab",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 73,
|
||||
"author": {
|
||||
"id": 24580
|
||||
},
|
||||
"writtenOn": "2019-07-30T17:54:05Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "7faddb67_d65e1e44",
|
||||
"range": {
|
||||
"startLine": 72,
|
||||
"startChar": 40,
|
||||
"endLine": 73,
|
||||
"endChar": 23
|
||||
},
|
||||
"revId": "2a58dd3457df06aa11dc1e63a0aa7acd768068b2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_512798b7",
|
||||
|
|
@ -57,6 +98,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_1dbfd2fb",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 78,
|
||||
"author": {
|
||||
"id": 24580
|
||||
},
|
||||
"writtenOn": "2019-07-30T17:54:05Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "7faddb67_512798b7",
|
||||
"revId": "2a58dd3457df06aa11dc1e63a0aa7acd768068b2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_112120a0",
|
||||
|
|
@ -103,6 +162,23 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_9caa0f17",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 93,
|
||||
"author": {
|
||||
"id": 24580
|
||||
},
|
||||
"writtenOn": "2019-07-30T17:54:05Z",
|
||||
"side": 1,
|
||||
"message": "Line 89 and 90: do we now have more details to add to the spec or plan to have supplemental spec in the near future? \nDoes the framework need some sorting of locking or transactional mechanism to prevent two writes stepping on each other or an update and deployment occurring simultaneously?",
|
||||
"revId": "2a58dd3457df06aa11dc1e63a0aa7acd768068b2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_519a38c5",
|
||||
|
|
@ -189,6 +265,40 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_42b4acd1",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 314,
|
||||
"author": {
|
||||
"id": 24580
|
||||
},
|
||||
"writtenOn": "2019-07-30T17:54:05Z",
|
||||
"side": 1,
|
||||
"message": "What is the option for users still on IPMI? Would the IPMI implementation a plugin to the boostrap cmd or replacing the bootstrap subcommands all together?\n\nCould we be clarify that airshipctl can support both redfish and ipmi?",
|
||||
"revId": "2a58dd3457df06aa11dc1e63a0aa7acd768068b2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_dd193a88",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 320,
|
||||
"author": {
|
||||
"id": 24580
|
||||
},
|
||||
"writtenOn": "2019-07-30T17:54:05Z",
|
||||
"side": 1,
|
||||
"message": "For developer, do we intend to provide VM option instead of baremetal?",
|
||||
"revId": "2a58dd3457df06aa11dc1e63a0aa7acd768068b2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_91b7503b",
|
||||
|
|
@ -212,6 +322,103 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_800d9536",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 359,
|
||||
"author": {
|
||||
"id": 24580
|
||||
},
|
||||
"writtenOn": "2019-07-30T17:54:05Z",
|
||||
"side": 1,
|
||||
"message": "more white spaces until line 372. more nits.",
|
||||
"revId": "2a58dd3457df06aa11dc1e63a0aa7acd768068b2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_a0f21105",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 408,
|
||||
"author": {
|
||||
"id": 24580
|
||||
},
|
||||
"writtenOn": "2019-07-30T17:54:05Z",
|
||||
"side": 1,
|
||||
"message": "in the BYO cluster use case, boostrap cmd is entirely optional, correct?",
|
||||
"revId": "2a58dd3457df06aa11dc1e63a0aa7acd768068b2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_60dc1974",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 431,
|
||||
"author": {
|
||||
"id": 24580
|
||||
},
|
||||
"writtenOn": "2019-07-30T17:54:05Z",
|
||||
"side": 1,
|
||||
"message": "typo?",
|
||||
"range": {
|
||||
"startLine": 431,
|
||||
"startChar": 34,
|
||||
"endLine": 431,
|
||||
"endChar": 39
|
||||
},
|
||||
"revId": "2a58dd3457df06aa11dc1e63a0aa7acd768068b2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_80958742",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 443,
|
||||
"author": {
|
||||
"id": 24580
|
||||
},
|
||||
"writtenOn": "2019-07-30T17:54:05Z",
|
||||
"side": 1,
|
||||
"message": "not sure if the sentence is complete as intended here? Did you mean all documents are CRDs or they could be something else?",
|
||||
"range": {
|
||||
"startLine": 442,
|
||||
"startChar": 92,
|
||||
"endLine": 443,
|
||||
"endChar": 12
|
||||
},
|
||||
"revId": "2a58dd3457df06aa11dc1e63a0aa7acd768068b2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_60edebb5",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 451,
|
||||
"author": {
|
||||
"id": 24580
|
||||
},
|
||||
"writtenOn": "2019-07-30T17:54:05Z",
|
||||
"side": 1,
|
||||
"message": "Is there any versioning info for bundle as in Deckhand 1.0 or is version handled in a different context/object?",
|
||||
"revId": "2a58dd3457df06aa11dc1e63a0aa7acd768068b2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_51e8f814",
|
||||
|
|
@ -228,6 +435,40 @@
|
|||
"revId": "2a58dd3457df06aa11dc1e63a0aa7acd768068b2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_93108350",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 565,
|
||||
"author": {
|
||||
"id": 24580
|
||||
},
|
||||
"writtenOn": "2019-07-30T17:54:05Z",
|
||||
"side": 1,
|
||||
"message": "looks nice. Would it be helpful to query for a given site/bundle or version, which/if deployed workflows are using it.",
|
||||
"revId": "2a58dd3457df06aa11dc1e63a0aa7acd768068b2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7faddb67_9395e389",
|
||||
"filename": "specs/approved/airshipctl.rst",
|
||||
"patchSetId": 15
|
||||
},
|
||||
"lineNbr": 604,
|
||||
"author": {
|
||||
"id": 24580
|
||||
},
|
||||
"writtenOn": "2019-07-30T17:54:05Z",
|
||||
"side": 1,
|
||||
"message": "should it also support the deletion of a site?",
|
||||
"revId": "2a58dd3457df06aa11dc1e63a0aa7acd768068b2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue