airship
/
specs
Code Issues Proposed changes

Update patch set 14 

Patch Set 14: Code-Review-1

(15 comments)

Patch-set: 14
Reviewer: Gerrit User 28208 <28208@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 28208 2019-07-05 15:56:37 +00:00 committed by Gerrit Code Review
parent d778239919
commit 56d3ce369d
1 changed files with 339 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

339
40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e
View File

@ -46,6 +46,29 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_339ed663",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 51,
"author": {
"id": 28208
},
"writtenOn": "2019-07-05T15:56:37Z",
"side": 1,
"message": "Mixed upper/lower case in numbered list after \u0027:\u0027.",
"range": {
"startLine": 51,
"startChar": 14,
"endLine": 51,
"endChar": 15
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_40571902",
@ -161,6 +184,115 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_53f03291",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 152,
"author": {
"id": 28208
},
"writtenOn": "2019-07-05T15:56:37Z",
"side": 1,
"message": "space",
"range": {
"startLine": 152,
"startChar": 72,
"endLine": 152,
"endChar": 73
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_b334064c",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 198,
"author": {
"id": 28208
},
"writtenOn": "2019-07-05T15:56:37Z",
"side": 1,
"message": "token: xxxxx\n\nKeeping username/password here is more unsafe. Token should probably expire after certain time.",
"range": {
"startLine": 197,
"startChar": 0,
"endLine": 198,
"endChar": 19
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_733e8e2a",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 217,
"author": {
"id": 28208
},
"writtenOn": "2019-07-05T15:56:37Z",
"side": 1,
"message": "line length",
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_73276e14",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 236,
"author": {
"id": 28208
},
"writtenOn": "2019-07-05T15:56:37Z",
"side": 1,
"message": "Stars (*) do not work here inside double back ticks to make text italic. Remove here and below.",
"range": {
"startLine": 236,
"startChar": 4,
"endLine": 236,
"endChar": 41
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_33ab361e",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 262,
"author": {
"id": 28208
},
"writtenOn": "2019-07-05T15:56:37Z",
"side": 1,
"message": "misplaced",
"range": {
"startLine": 262,
"startChar": 10,
"endLine": 262,
"endChar": 13
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_e525ffc2",
@ -207,6 +339,121 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_339256f8",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 327,
"author": {
"id": 28208
},
"writtenOn": "2019-07-05T15:56:37Z",
"side": 1,
"message": "should be no space before comma",
"range": {
"startLine": 327,
"startChar": 35,
"endLine": 327,
"endChar": 41
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_538fd2cb",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 329,
"author": {
"id": 28208
},
"writtenOn": "2019-07-05T15:56:37Z",
"side": 1,
"message": "should be no space before comma",
"range": {
"startLine": 329,
"startChar": 44,
"endLine": 329,
"endChar": 51
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_7388cec5",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 338,
"author": {
"id": 28208
},
"writtenOn": "2019-07-05T15:56:37Z",
"side": 1,
"message": "redundant spaces",
"range": {
"startLine": 338,
"startChar": 23,
"endLine": 338,
"endChar": 40
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_b36c0609",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 342,
"author": {
"id": 28208
},
"writtenOn": "2019-07-05T15:56:37Z",
"side": 1,
"message": "redundant spaces",
"range": {
"startLine": 342,
"startChar": 49,
"endLine": 342,
"endChar": 58
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_53fa7242",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 347,
"author": {
"id": 28208
},
"writtenOn": "2019-07-05T15:56:37Z",
"side": 1,
"message": "node Kubernetes cluster",
"range": {
"startLine": 347,
"startChar": 51,
"endLine": 347,
"endChar": 71
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_851e836d",
@ -276,6 +523,29 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_b3b72687",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 391,
"author": {
"id": 28208
},
"writtenOn": "2019-07-05T15:56:37Z",
"side": 1,
"message": "Upper case where needed for product names",
"range": {
"startLine": 391,
"startChar": 14,
"endLine": 391,
"endChar": 63
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_206d45cb",
@ -368,6 +638,29 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_f3191e88",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 493,
"author": {
"id": 28208
},
"writtenOn": "2019-07-05T15:56:37Z",
"side": 1,
"message": "wrong formatting",
"range": {
"startLine": 493,
"startChar": 0,
"endLine": 493,
"endChar": 26
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_000fe12d",
@ -391,6 +684,29 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_5e191977",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 550,
"author": {
"id": 28208
},
"writtenOn": "2019-07-05T15:56:37Z",
"side": 1,
"message": "incorrect link formatting",
"range": {
"startLine": 550,
"startChar": 36,
"endLine": 550,
"endChar": 77
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_654d8f98",
@ -436,6 +752,29 @@
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7faddb67_1e040115",
"filename": "specs/approved/airshipctl.rst",
"patchSetId": 14
},
"lineNbr": 632,
"author": {
"id": 28208
},
"writtenOn": "2019-07-05T15:56:37Z",
"side": 1,
"message": "wrong link formatting",
"range": {
"startLine": 632,
"startChar": 2,
"endLine": 632,
"endChar": 71
},
"revId": "40ef5a99c076ec5b49df27c0f41f3ba1ca97af1e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}