Update patch set 2

Patch Set 2: Code-Review-1

(5 comments)

Solid start. I think the general ideas are here, but some more analysis would be helpful before starting implementation.

Patch-set: 2
Reviewer: Gerrit User 28618 <28618@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1

2ef874290fc7a0ca16cdff7c65d2844b0abee6b9

@@ -0,0 +1,119 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "dfbec78f_4d1957d5",
+        "filename": "specs/approved/armada_time_metrics.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 39,
+      "author": {
+        "id": 28618
+      },
+      "writtenOn": "2019-05-06T20:43:32Z",
+      "side": 1,
+      "message": "I think this section should answer the following questions:\n\n1. What are the metrics Armada will capture? (e.g. full deployment time, upgrade time, wait time, install time)\n\n2. How is each metric defined? (e.g. full deployment time captures the install/upgrade, wait, and test times for a release)\n\n3. What data must be captured for the metrics? How/where is the data stored? How is it captured? (the capturing part appears to be called out in this spec, using a timer built-in to armada)\n\n5. How are the metrics communicated?",
+      "range": {
+        "startLine": 37,
+        "startChar": 0,
+        "endLine": 39,
+        "endChar": 48
+      },
+      "revId": "2ef874290fc7a0ca16cdff7c65d2844b0abee6b9",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "dfbec78f_8dc66f67",
+        "filename": "specs/approved/armada_time_metrics.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 56,
+      "author": {
+        "id": 28618
+      },
+      "writtenOn": "2019-05-06T20:43:32Z",
+      "side": 1,
+      "message": "trailing whitespace",
+      "range": {
+        "startLine": 56,
+        "startChar": 30,
+        "endLine": 56,
+        "endChar": 31
+      },
+      "revId": "2ef874290fc7a0ca16cdff7c65d2844b0abee6b9",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "dfbec78f_2d62e33f",
+        "filename": "specs/approved/armada_time_metrics.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 73,
+      "author": {
+        "id": 28618
+      },
+      "writtenOn": "2019-05-06T20:43:32Z",
+      "side": 1,
+      "message": "Another alternative would be using time data from Helm. I can\u0027t speak to whether or not this is more/less reliable or incomplete.\n\nBut that\u0027s also the purpose of this spec, so that would be helpful to explore and represent here.",
+      "range": {
+        "startLine": 73,
+        "startChar": 0,
+        "endLine": 73,
+        "endChar": 12
+      },
+      "revId": "2ef874290fc7a0ca16cdff7c65d2844b0abee6b9",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "dfbec78f_ad27b312",
+        "filename": "specs/approved/armada_time_metrics.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 81,
+      "author": {
+        "id": 28618
+      },
+      "writtenOn": "2019-05-06T20:43:32Z",
+      "side": 1,
+      "message": "elapsed",
+      "range": {
+        "startLine": 81,
+        "startChar": 67,
+        "endLine": 81,
+        "endChar": 75
+      },
+      "revId": "2ef874290fc7a0ca16cdff7c65d2844b0abee6b9",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "dfbec78f_ed5b6b84",
+        "filename": "specs/approved/armada_time_metrics.rst",
+        "patchSetId": 2
+      },
+      "lineNbr": 109,
+      "author": {
+        "id": 28618
+      },
+      "writtenOn": "2019-05-06T20:43:32Z",
+      "side": 1,
+      "message": "What does this mean?",
+      "range": {
+        "startLine": 107,
+        "startChar": 0,
+        "endLine": 109,
+        "endChar": 4
+      },
+      "revId": "2ef874290fc7a0ca16cdff7c65d2844b0abee6b9",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}