airship
/
specs
Code Issues Proposed changes

Update patch set 5 

Patch Set 5: Code-Review-1

(3 comments)

Patch-set: 5
Label: Code-Review=-1
This commit is contained in:
Gerrit User 20466 2019-06-27 12:40:40 +00:00 committed by Gerrit Code Review
parent 9180981a0e
commit 1f5148fc3a
1 changed files with 69 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

69
2dfc155f487a7b4eb8245ae8cc0a14d3778f001b
View File

@ -86,6 +86,29 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_3dcdac84",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 56,
"author": {
"id": 20466
},
"writtenOn": "2019-06-27T12:40:40Z",
"side": 1,
"message": "duration",
"range": {
"startLine": 56,
"startChar": 25,
"endLine": 56,
"endChar": 32
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_c18b5dbd",
@ -102,6 +125,52 @@
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_9dbcd8dc",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 116,
"author": {
"id": 20466
},
"writtenOn": "2019-06-27T12:40:40Z",
"side": 1,
"message": "nit: `` backtick",
"range": {
"startLine": 116,
"startChar": 0,
"endLine": 116,
"endChar": 30
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_1dd0e81e",
"filename": "specs/approved/armada_time_metrics.rst",
"patchSetId": 5
},
"lineNbr": 162,
"author": {
"id": 20466
},
"writtenOn": "2019-06-27T12:40:40Z",
"side": 1,
"message": "remove?",
"range": {
"startLine": 162,
"startChar": 0,
"endLine": 162,
"endChar": 4
},
"revId": "2dfc155f487a7b4eb8245ae8cc0a14d3778f001b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}