airship
/
shipyard
Code Issues Proposed changes

Remove 'task_result' Workaround 

All outstanding issues have been resolved in DryDock. We
expect 'task_result' to return 'success' only when task
is completed successfully.

This patch set removes the existing workarounds

Change-Id: Ifaae738c53b24395ff4a0316f86aadbc5ea8688b
This commit is contained in:
Anthony Lin 2018-02-21 17:20:48 +00:00 committed by Bryan Strassner
parent 35679d6754
commit f6d05cc966
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
shipyard_airflow/plugins/drydock_operators.py
View File

@ -389,15 +389,7 @@ class DryDockOperator(BaseOperator):
time.sleep(int(interval))
# Get final task result
# NOTE: The promenade join script does not have a call-back step
# to indicate that the process is completed at the moment. This
# will lead to Drydock returning 'partial success' at the end of
# the 'deploy_nodes' task as it times out while waiting for the
# response from promenade (bootactions will fail as a result). As
# such, we are keeping 'partial_success' as a valid task result
# for now and will update the Drydock Operator once the promenade
# feature is ready for consumption.
if task_result in ['success', 'partial_success']:
if task_result == 'success':
logging.info('Task id %s has been successfully completed',
self.task_id)
else: