From 95179f53fff03e9eb337d83d5d62f00fdbdeb09c Mon Sep 17 00:00:00 2001
From: Drew Walters <drewwalters96@gmail.com>
Date: Thu, 28 Mar 2019 16:59:11 -0500
Subject: [PATCH] CI: Add chart build job for latest Helm toolkit

This commit introduces a non-voting job to lint Helm charts against the
latest version of Helm toolkit from OpenStack-Helm Infra. This job
should serve as an indicator of when it's safe to advance the version of
Helm toolkit used by Airship.

Additionally, this commit modifies all Helm chart lint jobs to run on
each commit, regardless of the files modified by a change. This should
not introduce a noticeable difference in CI runtime, as these jobs
execute quicker than the tox jobs.

Change-Id: Ife3b285a2f9a160df9724e9dcb230243d06be3ab
---
 .zuul.yaml                             | 14 ++++++++++++--
 tools/gate/playbooks/build-charts.yaml | 11 +++++++----
 2 files changed, 19 insertions(+), 6 deletions(-)

diff --git a/.zuul.yaml b/.zuul.yaml
index c4b210c5..b8f7c636 100644
--- a/.zuul.yaml
+++ b/.zuul.yaml
@@ -21,6 +21,7 @@
       jobs:
         - openstack-tox-pep8
         - airship-shipyard-chart-build-gate
+        - airship-shipyard-chart-build-latest-htk
         - airship-shipyard-whitespace-lint-gate
         - airship-shipyard-image-gate
     gate:
@@ -41,11 +42,20 @@
 
 - job:
     name: airship-shipyard-chart-build-gate
+    description: Build charts using pinned Helm toolkit.
     timeout: 900
     run: tools/gate/playbooks/build-charts.yaml
     nodeset: airship-shipyard-single-node
-    files:
-      - ^charts/.*$
+
+- job:
+    name: airship-shipyard-chart-build-latest-htk
+    description: Build charts using latest Helm toolkit.
+    timeout: 900
+    voting: false
+    run: tools/gate/playbooks/build-charts.yaml
+    nodeset: airship-shipyard-single-node
+    vars:
+      HTK_COMMIT: master
 
 - job:
     name: airship-shipyard-whitespace-lint-gate
diff --git a/tools/gate/playbooks/build-charts.yaml b/tools/gate/playbooks/build-charts.yaml
index 4e93360a..8807e4a0 100644
--- a/tools/gate/playbooks/build-charts.yaml
+++ b/tools/gate/playbooks/build-charts.yaml
@@ -14,8 +14,11 @@
 
 - hosts: primary
   tasks:
-    - name: Build charts
-      shell: |
-        make charts
-      args:
+    - name: Execute the make target to package Helm charts.
+      make:
         chdir: "{{ zuul.project.src_dir }}"
+        target: charts
+        params:
+          HTK_COMMIT: "{{ HTK_COMMIT | default('') }}"
+      register: result
+      failed_when: result.failed