airship
/
promenade
Code Issues Proposed changes

Removing set -x from function 

Removing set -x from within the dump_databases_to_directory function.
The set -x from within the function is causing all the code that
follows the function call to have debug tracing on. This in turns
causing multiple identical logs for the same event. Looking at this
function, there should be enough logging to aid debugging.

Reference ps:  https://review.opendev.org/c/openstack/openstack-helm-infra/+/830533
               (commit 2fc1ce4a142e605a9fc6c90dceabbf7c4bfb81e3)

Change-Id: Id442972bbcca983afab7c4f3c29f3686e9e0b481
This commit is contained in:
Lo, Chi (cl566n) 2022-02-23 15:17:39 -08:00 committed by Chris Wedgwood
parent 54ed72284f
commit dc60ef8454
6 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
charts/etcd/templates/bin/_etcdbackup.tpl
View File

@ -36,7 +36,6 @@ export MAX_DELAY_SEND_REMOTE=${MAX_DELAY_SEND_BACKUP_TO_REMOTE}
export ARCHIVE_DIR=${BACKUP_DIR}/db/${DB_NAMESPACE}/${DB_NAME}/archive
dump_databases_to_directory() {
set -x
TMP_DIR=$1
LOG_FILE=${2:-BACKUP_LOG}

4
examples/basic/armada-resources.yaml
View File

@ -111,7 +111,7 @@ data:
type: git
location: https://git.openstack.org/openstack/openstack-helm-infra
subpath: helm-toolkit
reference: 4a490b894ce2a3c547075a5559de58fd07124401
reference: 2fc1ce4a142e605a9fc6c90dceabbf7c4bfb81e3
dependencies: []
---
schema: armada/Chart/v1
@ -135,7 +135,7 @@ data:
type: git
location: https://git.openstack.org/openstack/openstack-helm-infra
subpath: helm-toolkit
reference: 4a490b894ce2a3c547075a5559de58fd07124401
reference: 2fc1ce4a142e605a9fc6c90dceabbf7c4bfb81e3
dependencies: []
---
schema: armada/Chart/v1

4
examples/complete/armada-resources.yaml
View File

@ -152,7 +152,7 @@ data:
type: git
location: https://git.openstack.org/openstack/openstack-helm-infra
subpath: helm-toolkit
reference: 4a490b894ce2a3c547075a5559de58fd07124401
reference: 2fc1ce4a142e605a9fc6c90dceabbf7c4bfb81e3
dependencies: []
---
schema: armada/Chart/v1
@ -177,7 +177,7 @@ data:
type: git
location: https://git.openstack.org/openstack/openstack-helm-infra
subpath: helm-toolkit
reference: 4a490b894ce2a3c547075a5559de58fd07124401
reference: 2fc1ce4a142e605a9fc6c90dceabbf7c4bfb81e3
dependencies: []
---
schema: armada/Chart/v1

4
examples/containerd/armada-resources.yaml
View File

@ -111,7 +111,7 @@ data:
type: git
location: https://opendev.org/openstack/openstack-helm-infra.git
subpath: helm-toolkit
reference: 4a490b894ce2a3c547075a5559de58fd07124401
reference: 2fc1ce4a142e605a9fc6c90dceabbf7c4bfb81e3
dependencies: []
---
schema: armada/Chart/v1
@ -135,7 +135,7 @@ data:
type: git
location: https://opendev.org/openstack/openstack-helm-infra.git
subpath: helm-toolkit
reference: 4a490b894ce2a3c547075a5559de58fd07124401
reference: 2fc1ce4a142e605a9fc6c90dceabbf7c4bfb81e3
dependencies: []
---
schema: armada/Chart/v1

4
examples/gate/armada-resources.yaml
View File

@ -111,7 +111,7 @@ data:
type: git
location: https://opendev.org/openstack/openstack-helm-infra.git
subpath: helm-toolkit
reference: 4a490b894ce2a3c547075a5559de58fd07124401
reference: 2fc1ce4a142e605a9fc6c90dceabbf7c4bfb81e3
dependencies: []
---
schema: armada/Chart/v1
@ -135,7 +135,7 @@ data:
type: git
location: https://opendev.org/openstack/openstack-helm-infra.git
subpath: helm-toolkit
reference: 4a490b894ce2a3c547075a5559de58fd07124401
reference: 2fc1ce4a142e605a9fc6c90dceabbf7c4bfb81e3
dependencies: []
---
schema: armada/Chart/v1

2
tools/helm_tk.sh
View File

@ -17,7 +17,7 @@
set -eux
HTK_REPO=${HTK_REPO:-"https://opendev.org/openstack/openstack-helm-infra.git"}
HTK_STABLE_COMMIT=${HTK_COMMIT:-"11ac37056b1a45cdcdabe0aab239ab7fadd53b24"}
HTK_STABLE_COMMIT=${HTK_COMMIT:-"2fc1ce4a142e605a9fc6c90dceabbf7c4bfb81e3"}
TMP_DIR=$(mktemp -d)