From 02ae2bf0eeeec0754a634696a9ddaa2addd4601c Mon Sep 17 00:00:00 2001 From: Roman Gorshunov Date: Mon, 11 Feb 2019 18:14:20 +0100 Subject: [PATCH] Fix: flake8 tests failing due to invalid types comparison Change-Id: I7266c0740652da40858a5a34cec73452ed0e10e6 --- python/drydock_provisioner/ingester/ingester.py | 2 +- .../orchestrator/validations/ip_locality_check.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/python/drydock_provisioner/ingester/ingester.py b/python/drydock_provisioner/ingester/ingester.py index b64b6a41..34b4aa24 100644 --- a/python/drydock_provisioner/ingester/ingester.py +++ b/python/drydock_provisioner/ingester/ingester.py @@ -79,7 +79,7 @@ class Ingester(object): raise ValueError("Invalid design_state handler") # If no design_id is specified, instantiate a new one - if 'design_ref' is None: + if design_ref is None: self.logger.error( "Ingester:ingest_data required kwarg 'design_ref' missing") raise ValueError( diff --git a/python/drydock_provisioner/orchestrator/validations/ip_locality_check.py b/python/drydock_provisioner/orchestrator/validations/ip_locality_check.py index 5b1d238f..3df4f0ef 100644 --- a/python/drydock_provisioner/orchestrator/validations/ip_locality_check.py +++ b/python/drydock_provisioner/orchestrator/validations/ip_locality_check.py @@ -79,7 +79,7 @@ class IpLocalityCheck(Validators): address = ip_address.address ip_type = ip_address.type - if ip_type is not 'dhcp': + if ip_type != 'dhcp': if ip_address_network_name not in network_dict: msg = '%s is not a valid network.' \ % (ip_address_network_name)