airship
/
divingbell
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
CC: Gerrit User 28719 <28719@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 33949 \u003c33949@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Phil Sphicas replied on the change"}
This commit is contained in:
Gerrit User 28719 2022-01-18 17:50:47 +00:00 committed by Gerrit Code Review
parent 54ff83d772
commit 12229d25d0
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
076d26320221fd49d1ff66acba2b894036442543 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "e4b95170_2d2cb151",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 28719
},
"writtenOn": "2022-01-18T17:50:47Z",
"side": 1,
"message": "Can we do something for divingbell exec too, and also make it configurable through values.yaml?\n\nOne possibility ..\n\n conf:\n extra_verbose: false\n\nAnd then in https://review.opendev.org/plugins/gitiles/airship/divingbell/+/refs/changes/47/824747/1/divingbell/templates/bin/_shcommon.tpl#96\n\n {{- if .Values.conf.extra_verbose }}\n set -x\n {{- end }}\n\nOr per tool?\n\n conf:\n apt:\n extra_verbose: false\n exec:\n extra_verbose: false\n",
"revId": "076d26320221fd49d1ff66acba2b894036442543",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}