From 47b8d4d035bb6bb9a93ebc76024dcb24425c170b Mon Sep 17 00:00:00 2001 From: Tin Lam Date: Tue, 3 Oct 2017 00:19:58 -0500 Subject: [PATCH] Fix bandit [B101:assert_used] This patch set refactors the usage of assert in the python code. The current implementation does not emit assert statement when optimization is requested at compile time (with command line option -O). Thus, it may not be behaving the way one assumes. Change-Id: If2f2cac86eeae1de5974971b50a2342d8458e97c --- deckhand/db/sqlalchemy/api.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/deckhand/db/sqlalchemy/api.py b/deckhand/db/sqlalchemy/api.py index 72ce0429..cc3c2746 100644 --- a/deckhand/db/sqlalchemy/api.py +++ b/deckhand/db/sqlalchemy/api.py @@ -648,9 +648,7 @@ def revision_tag_create(revision_id, tag, data=None, session=None): session = session or get_session() tag_model = models.RevisionTag() - try: - assert not data or isinstance(data, dict) - except AssertionError: + if data and not isinstance(data, dict): raise errors.RevisionTagBadFormat(data=data) try: