airship
/
berth
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(2 comments)

Thank you for the review!

Patch-set: 1
Reviewer: Gerrit User 28208 <28208@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 28208 2018-09-21 01:42:49 +00:00 committed by Gerrit Code Review
parent 8276118120
commit 735f127ca7
1 changed files with 48 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
ba432cffe6ad36893a414bf01135a6f0493d7950
View File

@ -23,6 +23,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_ed17469c",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 9,
"author": {
"id": 28208
},
"writtenOn": "2018-09-21T01:42:49Z",
"side": 1,
"message": "OCI - Open Container Initiative",
"parentUuid": "3f79a3b5_8d2a52e4",
"range": {
"startLine": 9,
"startChar": 7,
"endLine": 9,
"endChar": 10
},
"revId": "ba432cffe6ad36893a414bf01135a6f0493d7950",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_0df9627e",
@ -45,6 +69,30 @@
"revId": "ba432cffe6ad36893a414bf01135a6f0493d7950",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f79a3b5_8d61f23b",
"filename": "Dockerfile",
"patchSetId": 1
},
"lineNbr": 6,
"author": {
"id": 28208
},
"writtenOn": "2018-09-21T01:42:49Z",
"side": 1,
"message": "According to the specification [0], it is an URL to get source code for building the image, supposed to be consumed by Git, not by browser. Git works perfectly with this URL.\n\n[0] https://github.com/opencontainers/image-spec/blob/master/annotations.md",
"parentUuid": "3f79a3b5_0df9627e",
"range": {
"startLine": 6,
"startChar": 39,
"endLine": 6,
"endChar": 88
},
"revId": "ba432cffe6ad36893a414bf01135a6f0493d7950",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}