8927c12f21
This patch set consolidates two distinct/disparate base exception classes together. Currently, Armada has base exceptions in armada/errors.py and armada/exceptions/base_exceptions.py -- the former of which is a port from Shipyard and the latter of which is "old-school" Armada code. The problem is that the two implementations are completely separate and different. Not only that, but Armada doesn't even appear to be using armada.errors which it should be as it implements the canonical UCP standard around error handling. So this patch set merges the two implementations together. Note, however, that Armada still doesn't use the same base exception for all its exceptions which is not ideal because -- again -- Armada should be making use of the UCP error handling logic. This is seen in the inheritance differentiation between `ArmadaBaseException` which inherits from Exception and `ArmadaAPIException` which inherits from `falcon.HTTPError`. More work is needed to ensure that each exception actually has an appropriate status code and that said status code is getting bubbled up to the end user/client/other server as appropriate. Change-Id: I7cf22fcbba4164f11fb01d9445ac575a14a5c3ab |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| api_exceptions.py | ||
| armada_exceptions.py | ||
| base_exception.py | ||
| chartbuilder_exceptions.py | ||
| k8s_exceptions.py | ||
| manifest_exceptions.py | ||
| override_exceptions.py | ||
| source_exceptions.py | ||
| tiller_exceptions.py | ||
| validate_exceptions.py | ||