From 65ce95f3a45e8d4d597ec33e7d7b27beaaa5022b Mon Sep 17 00:00:00 2001 From: Gage Hugo Date: Mon, 4 Jun 2018 17:53:42 -0500 Subject: [PATCH] Remove validate_manifest_filepath This change removes validate_manifest_filepath and its related test since it appears to only wrap around os.path.isfile() and isn't used anywhere else within armada[0]. [0] https://github.com/openstack/airship-armada/search?utf8=%E2%9C%93&q=validate_manifest_filepath Change-Id: I014045e4e4d4087780cf99ece1a2049148db8c5d --- armada/tests/unit/utils/test_validate.py | 7 ------- armada/utils/validate.py | 5 ----- 2 files changed, 12 deletions(-) diff --git a/armada/tests/unit/utils/test_validate.py b/armada/tests/unit/utils/test_validate.py index 4dc03262..3267adc2 100644 --- a/armada/tests/unit/utils/test_validate.py +++ b/armada/tests/unit/utils/test_validate.py @@ -218,13 +218,6 @@ data: 'airship-armada/master/examples/simple.yaml' self.assertTrue(validate.validate_manifest_url(value)) - def test_validate_manifest_filepath(self): - value = 'filepath' - self.assertFalse(validate.validate_manifest_filepath(value)) - value = '{}/resources/valid_armada_document.yaml'.format( - self.basepath) - self.assertTrue(validate.validate_manifest_filepath(value)) - class ValidateNegativeTestCase(BaseValidateTest): diff --git a/armada/utils/validate.py b/armada/utils/validate.py index 17bd99e3..0dd602a9 100644 --- a/armada/utils/validate.py +++ b/armada/utils/validate.py @@ -234,10 +234,5 @@ def validate_manifest_url(value): return False -# TODO(MarshM) unused except in unit tests, is this useful? -def validate_manifest_filepath(value): - return os.path.isfile(value) - - # Fill the cache. _load_schemas()