From 48c7e540cab2cb69091d5be52220f23019a48f81 Mon Sep 17 00:00:00 2001
From: Felipe Monteiro <felipe.monteiro@att.com>
Date: Tue, 19 Dec 2017 15:34:39 +0000
Subject: [PATCH] fix(tox): Add whitelist externals to tox.ini to avoid
 warnings

This PS adds whitelist externals to Armada's tox.ini to avoid
warnings that are issued while running tox -e py35 or tox -e pep8.
Example:

WARNING:test command found but not installed in testenv
  cmd: /usr/bin/find
  env: /opt/stack/armada/.tox/py35

This PS also resolves a critical error while running
tox -e coverage, because tox defaults to python2.7 for
the coverage job, and Armada's hapi module is not compatible
with python2.7. The fix involves setting the testenv's
basepython to python3.5.

Change-Id: Ice0074c3453c80290886f27a4518fbed01722572
---
 tox.ini | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tox.ini b/tox.ini
index a7593871..81c851e1 100644
--- a/tox.ini
+++ b/tox.ini
@@ -9,8 +9,11 @@ deps=
 passenv=HTTP_PROXY HTTPS_PROXY http_proxy https_proxy NO_PROXY no_proxy
 setenv=
     VIRTUAL_ENV={envdir}
+basepython = python3.5
 usedevelop = True
 install_command = pip install {opts} {packages}
+whitelist_externals = find
+                      flake8
 commands =
   find . -type f -name "*.pyc" -delete
   python -V
@@ -38,7 +41,7 @@ commands =
 
 [testenv:coverage]
 commands =
-  pytest \
+  python -m pytest \
     --cov-branch \
     --cov-report term-missing:skip-covered \
     --cov-config .coveragerc \