From c6fb131022989905e95ce8e79b7f7b492f06f814 Mon Sep 17 00:00:00 2001
From: Drew Walters <drewwalters96@gmail.com>
Date: Thu, 28 Mar 2019 15:31:21 +0000
Subject: [PATCH] CI: Add chart build job for latest Helm toolkit

This commit introduces a non-voting job to lint Helm charts against the
latest version of Helm toolkit from OpenStack-Helm Infra. This job
should serve as an indicator of when it's safe to advance the version of
Helm toolkit used by Airship.

Additionally, this commit modifies all Helm chart lint jobs to run on
each commit, regardless of the files modified by a change. This should
not introduce a noticeable difference in CI runtime, as these jobs
execute quicker than the tox jobs.

Change-Id: I6c205d983a9556120ec9ce7ed70a44e7286eb6dd
---
 .zuul.yaml                             | 16 ++++++++++++++--
 tools/gate/playbooks/build-charts.yaml | 11 +++++++----
 2 files changed, 21 insertions(+), 6 deletions(-)

diff --git a/.zuul.yaml b/.zuul.yaml
index 3ea8e40c..302d928e 100644
--- a/.zuul.yaml
+++ b/.zuul.yaml
@@ -22,6 +22,7 @@
       jobs:
         - openstack-tox-pep8
         - airship-armada-chart-build-gate
+        - airship-armada-chart-build-latest-htk
         - airship-armada-docker-build-gate
     gate:
       jobs:
@@ -40,11 +41,22 @@
 
 - job:
     name: airship-armada-chart-build-gate
+    description: |
+      Builds Armada and Tiller charts using pinned Helm toolkit.
     timeout: 900
     run: tools/gate/playbooks/build-charts.yaml
     nodeset: airship-armada-single-node
-    files:
-      - ^charts/.*$
+
+- job:
+    name: airship-armada-chart-build-latest-htk
+    description: |
+      Builds Armada and Tiller charts using latest Helm toolkit.
+    timeout: 900
+    voting: false
+    run: tools/gate/playbooks/build-charts.yaml
+    nodeset: airship-armada-single-node
+    vars:
+      HTK_COMMIT: master
 
 - job:
     name: airship-armada-docker-build-gate
diff --git a/tools/gate/playbooks/build-charts.yaml b/tools/gate/playbooks/build-charts.yaml
index 4e93360a..8807e4a0 100644
--- a/tools/gate/playbooks/build-charts.yaml
+++ b/tools/gate/playbooks/build-charts.yaml
@@ -14,8 +14,11 @@
 
 - hosts: primary
   tasks:
-    - name: Build charts
-      shell: |
-        make charts
-      args:
+    - name: Execute the make target to package Helm charts.
+      make:
         chdir: "{{ zuul.project.src_dir }}"
+        target: charts
+        params:
+          HTK_COMMIT: "{{ HTK_COMMIT | default('') }}"
+      register: result
+      failed_when: result.failed