airship
/
airship-in-a-bottle
Code Issues Proposed changes

Update patch set 26 

Patch Set 26:

(2 comments)

Patch-set: 26
This commit is contained in:
Gerrit User 28690 2019-12-10 15:49:23 +00:00 committed by Gerrit Code Review
parent 61547b9124
commit ff873ed8ba
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
6e862a0845a977ffe5af26999bca7fd4d399004e
View File

@ -17,6 +17,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_85f800c1",
"filename": "tools/multi_nodes_gate/airship_gate/stages/build-scripts.sh",
"patchSetId": 26
},
"lineNbr": 0,
"author": {
"id": 28690
},
"writtenOn": "2019-12-10T15:49:23Z",
"side": 1,
"message": "Alex, we have update the pegleg build-all with promenade genesis_bundle. pegleg still internally uses promenade to create genesis bundle. So it expects few Promenade specific env vars to be set",
"parentUuid": "3fa7e38b_3cbefe64",
"revId": "6e862a0845a977ffe5af26999bca7fd4d399004e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_95a1c3ab",
@ -33,6 +51,24 @@
"revId": "6e862a0845a977ffe5af26999bca7fd4d399004e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_e5e1b4d0",
"filename": "tools/multi_nodes_gate/airship_gate/stages/build-scripts.sh",
"patchSetId": 26
},
"lineNbr": 111,
"author": {
"id": 28690
},
"writtenOn": "2019-12-10T15:49:23Z",
"side": 1,
"message": "Agreed, we had issues with pegleg collect. with this change the script directory itself is created by the genesis-bundle step and i have not noticed any permission issue.",
"parentUuid": "3fa7e38b_95a1c3ab",
"revId": "6e862a0845a977ffe5af26999bca7fd4d399004e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}