airship
/
airship-in-a-bottle
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

(1 comment)

Patch-set: 4
Reviewer: Gerrit User 28628 <28628@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 28628 2019-12-04 15:29:44 +00:00 committed by Gerrit Code Review
parent cdbb72b22a
commit fc123bae2f
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
4932e05257f45f478d0291fc36369591ac9edf24
View File

@ -22,6 +22,30 @@
"revId": "4932e05257f45f478d0291fc36369591ac9edf24",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_2b4daf70",
"filename": "tools/multi_nodes_gate/airship_gate/lib/config.sh",
"patchSetId": 4
},
"lineNbr": 16,
"author": {
"id": 28628
},
"writtenOn": "2019-12-04T15:29:44Z",
"side": 1,
"message": "My main reason is to avoid users having to change the name of their override variable in their environments, and because unlike other tools (such as drydock, shipyard, etc.) the only way this tool is tied to airship-in-a-bottle is through its BGP implementation, so changing this again in the future (if need be) is not out of the question.",
"parentUuid": "3fa7e38b_e5b7c684",
"range": {
"startLine": 16,
"startChar": 7,
"endLine": 16,
"endChar": 16
},
"revId": "4932e05257f45f478d0291fc36369591ac9edf24",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}